docs: deprecate verifyClient #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this, rubber stamp LGTM. There are a few nits I would like to address. I will specify them later. |
lpinca
reviewed
Aug 4, 2019
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
lpinca
reviewed
Aug 4, 2019
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
lpinca
reviewed
Aug 4, 2019
Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
lpinca
approved these changes
Aug 4, 2019
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted #1612 to update
verifyClientbecause I was unaware of #377 (comment)This discussion has been going on since 2014 so I figured it would be useful to update some of the examples and docs to save someone else from making the mistake I did 😄
This change:
verifyClientverifyClient